Fix/bug 424 review next cache race #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @karimodm I'm a little confused by the status shown by GitHub
Do you know why it is saying "lint_and_test Expected — Waiting for status to be reported"? My experience is that this only displays temporarily whilst the test is being performed (a minute or two) Cheers |
karimodm
force-pushed
the
fix/bug-424-review-next-cache-race
branch
from
b52485c
to
25cbabc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #424 and #582 (duplicate)
Bonus: avoids syncing for the whole vault by changing scheduledNotes within the reviewDecks in-place.